Move rank scan implementations from scan_inclusive.cu to rank_scan.cu #9351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9351 +/- ##
================================================
- Coverage 10.79% 10.74% -0.05%
================================================
Files 116 116
Lines 18869 19038 +169
================================================
+ Hits 2036 2045 +9
- Misses 16833 16993 +160
Continue to review full report at Codecov.
|
davidwendt
added
3 - Ready for Review
jrhemstad
approved these changes
Oct 4, 2021
vuule
approved these changes
Oct 4, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was mainly to improve the compile time for
reductions/scan/scan_inclusive.cuby refactoring out the rank-scan functions into a separate filerank.cu. Although the overall compile time improvement forscan_inclusive.cuis only 25%, the source code is better organized with this change. The code function has changed.The detail
inclusive_rank_scanandinclusive_dense_rank_scandeclarations were moved fromsrc/reductions/scan/scan.cuhtoinclude/cudf/detail/scan.hppand dispatching of the RANK and DENSE_RANK aggregation is done inscan.cppinstead of handled byscan_inclusive.cuand alsoscan_exclusive.cu(which just throws an exception anyway).